Update/Revise the "Browser not supported" message.

Zydrolic

this is a pretty small issue but it's only because the message itself is outdated with its requirements (And as mentioned later on by @ajskateboarder — it's only checking for IE, which I actually did not realize LOL)

found the line in github (browser-modal.jsx line 46-52)

Now, this is quite ambigious (up for interpretation), have your ways. I'm not a HTML coder, I merely edited the original code and I have no idea how to check user-agent lol, however I feel as this would be better off in a github issue now that I think ‘bout it, people over there might resolve this better. If an issue on the scratch-www github (or any scratch-related page that contains a mention of this in general) exists, I’ll close this as then it's extraneous to keep as people on the github pages probably know alot better.

So I'd realized (while looking for the banner color for a question on QaS) that the unsupported browser message is actually somewhat outdated (atleast judging from the code):

Red means outdated.
The code itself incase someone wishes to read it instead of directly grabbing it from just using inspect element (F12 or right click + inspect element):

[if lte IE 8]>
  <div class="unsupported-browser banner" data-cue="unsupported_browser">
    <div class="container">
      <span>Scratch supports Internet Explorer 9+. We suggest you upgrade to <a href="/info/faq/#requirements">a supported browser</a>, <a href="/scratch2download/">download the offline editor</a>, or <a href="https://en.scratch-wiki.info/wiki/List_of_Bug_Workarounds">read about common workarounds</a>.</span>
    </div>
  </div>
  <![endif]

Since it's currently out of date (and I cannot appear to find a suggestion related to updating or revising it, why not?)

Now I'm not a HTML Coder (i merely try to understand it at times) so I don't really have anything else other than having this revised version I thought of:

Unsupported Browser (Revise) wrote:
Your current browser is not supported, Scratch supports Chrome 63+, Edge 15+, Firefox 57+, Safari 11+. We suggest that you update to a supported browser or change to a supported browser (see “What are the requirements for Scratch?”), download the offline editor, or read about common workarounds.

As an attempt of recreating this in HTML though I doubt I did it right:

[if lte IE 8]>
  <div class="unsupported-browser banner" data-cue="unsupported_browser">
    <div class="container">
      <span>Your current browser is not supported, Scratch supports Chrome 63+, Edge 15+, Firefox 57+, Safari 11+. We suggest that you <a href="/info/faq/#requirements">update to a supported browser or change to a supported browser (see "What are the requirements for Scratch?")</a>, <a href="/download">download the offline editor</a>, or <a href="https://en.scratch-wiki.info/wiki/List_of_Bug_Workarounds">read about common workarounds</a>.</span>
    </div>
  </div>
  <![endif]

Mainly saying this because Internet Explorer's support was actually cut anyway. Although I doubt anyone is even using IE 8 these days.

or just update the message to use the newer URLs (/download and remove #requirements from the URL, or just re-add requirements as a section to the FAQ)
EDIT: Fixed something (I forgot what I fixed)
EDIT2: made “HTML” in the [code=HTML]…[/code] tag lowercase so its recognized. The code line doesn't load for me so I can't view it (for whatever reason).

Last edited by Zydrolic (Nov. 4, 2023 21:11:39)

scratchcode1_2_3

Support! It's actually kinda weird that it hasn't been updated yet, including the fact that IE doesn't even let you use it anymore and redirects you to Microsoft Edge and you have to do a bunch of extra steps to get it blah blah blah

And also, you did good with the HTML! Let me test it out…

Yup! Works just fine

medians

Actually, it might not matter that much though because (at least when I last checked) /scratch2download redirects to /download

scratchcode1_2_3 wrote:
Support! It's actually kinda weird that it hasn't been updated yet, including the fact that IE doesn't even let you use it anymore and redirects you to Microsoft Edge and you have to do a bunch of extra steps to get it blah blah blah

And also, you did good with the HTML! Let me test it out…

Yup! Works just fine

This is only on scratchr2 pages.

scratchcode1_2_3

medians wrote:
(#3)
Actually, it might not matter that much though because (at least when I last checked) /scratch2download redirects to /download
scratchcode1_2_3 wrote:
Support! It's actually kinda weird that it hasn't been updated yet, including the fact that IE doesn't even let you use it anymore and redirects you to Microsoft Edge and you have to do a bunch of extra steps to get it blah blah blah

And also, you did good with the HTML! Let me test it out…

Yup! Works just fine
This is only on scratchr2 pages.

ye

I've seen the 3.0 one before, but it's just a bit of text, right? I would say it would take a maximum of a month to fix

edit: wait why does the div actually work in 3.0 pages

Last edited by scratchcode1_2_3 (Oct. 1, 2023 21:27:58)

medians

scratchcode1_2_3 wrote:
I've seen the 3.0 one before, but it's just a bit of text, right? I would say it would take a maximum of a month to fix

edit: wait why does the div actually work in 3.0 pages

scratch-www might use similar class names then or sth.

ajskateboarder

Zydrolic wrote:

As an attempt of recreating this in HTML though I doubt I did it right:

[if lte IE 8]>
  <div class="unsupported-browser banner" data-cue="unsupported_browser">
    <div class="container">
      <span>Your current browser is not supported, Scratch supports Chrome 63+, Edge 15+, Firefox 57+, Safari 11+. We suggest that you <a href="/info/faq/#requirements">update to a supported browser or change to a supported browser (see "What are the requirements for Scratch?")</a>, <a href="/download">download the offline editor</a>, or <a href="https://en.scratch-wiki.info/wiki/List_of_Bug_Workarounds">read about common workarounds</a>.</span>
    </div>
  </div>
  <![endif]

This code - the [if lte IE 8]> part specifically - is specific to IE and other browsers will just ignore it (Silly Microsoft haha), so you will need some other logic for checking if the browser is unsupported. Perhaps the user agent?

Zydrolic

scratchcode1_2_3 wrote:
(#2)
Support! It's actually kinda weird that it hasn't been updated yet, including the fact that IE doesn't even let you use it anymore and redirects you to Microsoft Edge and you have to do a bunch of extra steps to get it blah blah blah

And also, you did good with the HTML! Let me test it out…

Yup! Works just fine

it's honestly fair that its somewhat out of date (atleast in wording) because they have alot more important things to deal with most likely
also nice since i just edited the code lol

medians wrote:
(#3)
Actually, it might not matter that much though because (at least when I last checked) /scratch2download redirects to /download

Yeah it does redirect to download, lol im blind

ajskateboarder wrote:
(#6)
This code - the > part specifically - is specific to IE and other browsers will just ignore it (Silly Microsoft haha), so you will need some other logic for checking if the browser is unsupported. Perhaps the user agent?

Yeaaa i was lazy to edit since I barely edit HTML (so I just kept IE 8 in instead)

NotK3ndricAlt

It should say that it supports mobile devices also.

Zydrolic

NotK3ndricAlt wrote:
(#8)
It should say that it supports mobile devices also.

This is still assuming that the user is using PC, however I'll do it I guess.
EDIT: Nevermind — I can't think of any way it'd fit.

Last edited by Zydrolic (Oct. 2, 2023 15:42:22)

gdfsgdfsgdfg

Zydrolic wrote:
NotK3ndricAlt wrote:
(#8)
It should say that it supports mobile devices also.
This is still assuming that the user is using PC, however I'll do it I guess.
EDIT: Nevermind — I can't think of any way it'd fit.

I think the version on mobile is the same as pc
thats what I think on chrome
My browser / operating system: IPad iOS 16.6, ChromeiOS 117.0.5938.117, No Flash version detected

Last edited by gdfsgdfsgdfg (Oct. 2, 2023 15:52:40)

Zydrolic

gdfsgdfsgdfg wrote:
(#10)
I think the version on mobile is the same as pc
thats what I think on chrome
My browser / operating system: IPad iOS 16.6, ChromeiOS 117.0.5938.117, No Flash version detected

It is the same (atleast judging from trying to look for any mobile-check in HTML)

Zydrolic

bruhmp

Zydrolic

Zydrolic wrote:
(#12)
bruhmp

bruhmp 2

Zydrolic

Zydrolic wrote:
(#11)
gdfsgdfsgdfg wrote:
(#10)
I think the version on mobile is the same as pc
thats what I think on chrome
My browser / operating system: IPad iOS 16.6, ChromeiOS 117.0.5938.117, No Flash version detected
It is the same (atleast judging from trying to look for any mobile-check in HTML)

(an edit would be basically worthless now)
Just to clarify I'd snooped around in other parts of the HTML (other than the browser checksum itself) and it indeed doesn't have a check
EDIT: Fixed it up

Last edited by Zydrolic (Oct. 4, 2023 19:46:30)

Zydrolic

Bruhmp again, discussion is basically like a 404 on this

Zydrolic

bump bruhmp

Last edited by Zydrolic (Oct. 6, 2023 16:34:35)

Zydrolic

bad bruhmp

medians

Zydrolic wrote:
medians wrote:
(#3)
Actually, it might not matter that much though because (at least when I last checked) /scratch2download redirects to /download
Yeah it does redirect to download, lol im blind

Also, for some reason I didn't realize /info/faq moved for a second, but that one redirects to /faq. The resources part of the footer on scratchr2 still is /info/faq by the way.

Zydrolic

medians wrote:
(#18)
Also, for some reason I didn't realize /info/faq moved for a second, but that one redirects to /faq. The resources part of the footer on scratchr2 still is /info/faq by the way.

Well I guess those could be updated but
that's a different suggestion
EDIT: Aka probably not here lol

Last edited by Zydrolic (Oct. 7, 2023 16:30:10)

Zydrolic

bruhmp

Discuss Scratch